Skip to content

Conversation

@srzeszut
Copy link
Contributor

No description provided.

@srzeszut srzeszut linked an issue Dec 22, 2025 that may be closed by this pull request
end

@sessions 2
feature "debugger captures runtime errors and exceptions in global callbacks pt.2", %{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single test takes too long and times out.

@srzeszut srzeszut marked this pull request as ready for review January 9, 2026 10:03
@kraleppa
Copy link
Member

Some UI stuff:

  1. Fullscreen and copy icons and overlap
Screenshot 2026-01-13 at 15 50 37
  1. This violet gap is definitely too big, I'd consider removing it entirely
Screenshot 2026-01-13 at 15 51 25
  1. Is there an option to remove tab at the beginning of these stacktrace records, force them to be oneline, and if they doesn't fit add x-axis scrollbar? I think it may make it easier to read
Screenshot 2026-01-13 at 15 52 23
  1. The gap between "!" icon and the error name should be bigger and I'd consider removing these stars if they're not neccessary
Screenshot 2026-01-13 at 15 54 48
  1. Why gap between callback name and timestamp is smaller in case of exception than the same gap in case of standard trace?
Screenshot 2026-01-13 at 15 56 15
  1. The "!" icon is changing its width when you change the width of the window
Screen.Recording.2026-01-13.at.16.01.09.mov

@srzeszut srzeszut requested a review from kraleppa January 19, 2026 08:13
@kraleppa
Copy link
Member

Nice, couple UI nitpicks:

  1. Exception is not visible in the fullscreen (check figma)
Screenshot 2026-01-19 at 11 34 56
  1. I don't see a reason on why we should have button that opens fullscreen modal inside the modal... 😅
Screenshot 2026-01-19 at 11 37 34
  1. These gaps should be the same size. Also, I think the fullscreen button could be on the right and copy button on the left so the fullscreen button does not jump when you switch exception tabs
Screenshot 2026-01-19 at 11 39 30

@kraleppa
Copy link
Member

kraleppa commented Jan 19, 2026

Also, I noticed that this gap is much bigger on your branch than on main. Can it be fixed so we use full width of this element?

main:
Screenshot 2026-01-19 at 11 45 51

this branch:
Screenshot 2026-01-19 at 11 46 21

@kraleppa
Copy link
Member

One more thing when it comes to UI - can you make fullscreen header of error trace and standard trace look the same? Exception callback in fullscreen mode has timestamp, execution time and even module name (which is not displayed in node inspector traces at all), and at the same time standard callbacks has only function name.

So the standard approach till now was in fullscreen we display only function name in the header (or Diff sent). But I actually like the fact that we display timestamp and execution time, and we could go this way

So we could display in the fullscreen header:

  • function name (or Diff sent) - always
  • timestamp + execution time / diff size - always
  • callback module - only in global callback traces
  • exception - only in case of exceptions

Ofc we need to also make sure that these headers are cohesive with headers in global callback traces.

Screenshot 2026-01-21 at 10 18 18 Screenshot 2026-01-21 at 10 18 06

What do you think?

Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're ready to merge after resolving the above issue

@kraleppa kraleppa requested a review from hhubert6 January 21, 2026 09:54
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are timestamps and execution times should behave like this?:

  • when closed on wider screen
Image
  • when opened
Image

Aren't they supposed to stick to the right side all the time (they are on designs at least)

And I don't know if it's just me but in dark mode in trace fullscreen (when exceptioned) those header have black text instead of white. Also there is the infamous issue with tooltips and modals (shown below):

Image

@srzeszut
Copy link
Contributor Author

Are timestamps and execution times should behave like this?:

  • when closed on wider screen
Image * when opened Image Aren't they supposed to stick to the right side all the time (they are on designs at least)

And I don't know if it's just me but in dark mode in trace fullscreen (when exceptioned) those header have black text instead of white. Also there is the infamous issue with tooltips and modals (shown below):

Image

Now it should work as before.

Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fullscreen of trace with exception should expand the same way as regular one, which is take maximal space.

Image Image

@srzeszut srzeszut requested review from hhubert6 and kraleppa January 22, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better handling of callbacks exceptions

4 participants