-
Notifications
You must be signed in to change notification settings - Fork 20
Enhancement: Add better handling of callbacks exceptions #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
test/e2e/exception_trace_test.exs
Outdated
| end | ||
|
|
||
| @sessions 2 | ||
| feature "debugger captures runtime errors and exceptions in global callbacks pt.2", %{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single test takes too long and times out.
…lbacks-exceptions
…f-callbacks-exceptions
|
Nice, couple UI nitpicks:
|
kraleppa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're ready to merge after resolving the above issue
hhubert6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are timestamps and execution times should behave like this?:
- when closed on wider screen
- when opened
Aren't they supposed to stick to the right side all the time (they are on designs at least)
And I don't know if it's just me but in dark mode in trace fullscreen (when exceptioned) those header have black text instead of white. Also there is the infamous issue with tooltips and modals (shown below):
…f-callbacks-exceptions
hhubert6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

















No description provided.