Skip to content

[SceneChecking] Collision: new checker on the presence of a pipeline and models #5839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fredroy wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[SceneChecking] Collision: new checker on the presence of a pipeline and models #5839

fredroy wants to merge 4 commits into from
+247 −0

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Dec 22, 2025 •
edited
Loading

Some scenes has a whole collision pipeline but no collision in their scene whatsoever, 99% because of copy paste.

This checker just checks if there is a collision pipeline, and warns if there is no collision models (and vice versa)

[with-all-tests]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added this to the v26.06 milestone Dec 22, 2025
@fredroy fredroy added pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Dec 22, 2025
@fredroy fredroy force-pushed the add_collision_components_check branch from 5275e54 to a0ea0c8 Compare December 23, 2025 04:45
@fredroy fredroy mentioned this pull request Dec 23, 2025
Open
@fredroy
Copy link
Contributor Author

fredroy commented Jan 4, 2026

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

@bakpaul bakpaul bakpaul approved these changes

Assignees

No one assigned

Labels

pr: enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

v26.06

Development

Successfully merging this pull request may close these issues.

4 participants

@fredroy @hugtalbot @bakpaul @epernod