[FileSystem] Add openFileWithDefaultApplication method #5798
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
the
pr: status to review
hugtalbot
added
pr: enhancement
fredroy
requested changes
Dec 4, 2025
| success = true; | ||
| #elif defined(__APPLE__) | ||
| const std::string command = "open \"" + filename + "\""; | ||
| if (std::system(command.c_str()) == 0) |
Contributor
There was a problem hiding this comment.
std::system() is not safe ; as a user could call this function with an input crafted to do malicious things...
So the solution would be to sanitize the inputs or the best solution is to use fork() and execvp() (for linux at least.)
Contributor
Author
There was a problem hiding this comment.
I see, sorry I didn't know it was bad practice to use std::system. I'll make the changes for both macOS and linux.
Contributor
Author
There was a problem hiding this comment.
I have replaced std::system with posix_spawn for Linux and popen for MacOS.
I haven't tested the MacOS implementation.
EulalieCoevoet
added
pr: status to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to open the file where a node or component is implemented or instantiate (see SofaComplianceRobotics/SofaGLFW#92)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if