Sanitize strings by removing lone surrogates#82
Merged
darrachequesne merged 1 commit intosocketio:masterfrom Dec 21, 2016
Merged
Sanitize strings by removing lone surrogates#82darrachequesne merged 1 commit intosocketio:masterfrom
darrachequesne merged 1 commit intosocketio:masterfrom
Conversation
|
Is there a corresponding |
Member
Author
|
@calzoneman do you have a failing test-case? EDIT: invalid utf8 is already covered, isn't it? |
|
I don't; I just noticed that you mentioned that invalid continuation byte errors are handled by the try-catch, and I didn't see one for encoding. But if you've checked that that's already covered, that's fine. |
Member
Author
|
Yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #68
Using a local
utf8.jsfile, until mathiasbynens/utf8.js#19 is merged.The
strict: falseflag make the encoder/decoder replace every lone surrogate with theU+FFFDcharacter, instead of throwingLone surrogate U+... is not a scalar value.Note:
wtf-8package isutf8without thecheckScalarValue, throwing the former error.Invalid continuation byte) can still happen when decoding, but are caught within the try..catchcc @Nibbler999 @calzoneman