implement AUTH PLAIN #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AUTH LOGIN is no longer the default from the looks, AUTH PLAIN appears to be more common.
I ran into a server that did not support AUTH LOGIN at all, so I implemented AUTH PLAIN as an optional toggle.
The default behavior remains unchanged, calling `setLogin('<user>', '<pwd>', true)` instead of `setLogin('<user>', '<pwd>')` will use AUTH PLAIN.
AUTH LOGIN is no longer the default from the looks, AUTH PLAIN appears to be more common.
I ran into a server that did not support AUTH LOGIN at all, so I implemented AUTH PLAIN as an optional toggle.
The default behavior remains unchanged, calling `setLogin('<user>', '<pwd>', true)` instead of `setLogin('<user>', '<pwd>')` will use AUTH PLAIN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTH LOGIN is no longer the default from the looks, AUTH PLAIN appears to be more common.
I ran into a server that did not support AUTH LOGIN at all, so I implemented AUTH PLAIN as an optional toggle.
The default behavior remains unchanged, calling
setLogin('<user>', '<pwd>', true)instead ofsetLogin('<user>', '<pwd>')will use AUTH PLAIN.I also amended the readme to describe this usage.