Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

feat(benches): ivc_scaling_benchmark #422

Merged
cyphersnake merged 3 commits into from
Feb 26, 2025
Merged

feat(benches): ivc_scaling_benchmark #422

cyphersnake merged 3 commits into from
Feb 26, 2025

Conversation

@cyphersnake
Copy link
Contributor

@cyphersnake cyphersnake commented Feb 17, 2025

Motivation
To test the performance of the cyclefold

Overview
One new benchmark has been added, there is a step circuit within it that allows you to group other step circuits. This is done for simplicity, so that you can easily increase the number of gates

Also, the repetitive test-poseidion-circuit code was moved into a separate module within the main project

@cyphersnake cyphersnake requested a review from chaosma February 17, 2025 21:17
@cyphersnake cyphersnake self-assigned this Feb 17, 2025
@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2025 •
edited
Loading

Warning

Rate limit exceeded

@cyphersnake has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 4e51b1c and 0af0d22.

📒 Files selected for processing (8)
  • Cargo.toml (1 hunks)
  • benches/ivc_gate_scaling.rs (1 hunks)
  • examples/cli.rs (1 hunks)
  • examples/cyclefold_poseidon.rs (1 hunks)
  • examples/sangria_poseidon.rs (3 hunks)
  • examples/sha256/main.rs (4 hunks)
  • src/gadgets/mod.rs (1 hunks)
  • src/gadgets/poseidon_step_circuit.rs (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

chaosma
chaosma approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@chaosma chaosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, what is the performance result of sha256 using cyclefold+protogalaxy

Base automatically changed from perf-cyclefold-2 to main February 26, 2025 10:33
@cyphersnake
refactor(examples): fix DRY for PoseidonStepCircuit
e16f97a 
**Motivation**
Fix DRY

**Overview**
Move example test circuit into main repo
@cyphersnake
feat(examples): sha256 -> cyclefold
5c10f54 
**Motivation**
There is no point of sangria::IVC for this circuit, due to the number of its gates

**Overview**
N/A
@cyphersnake
feat(bench): add ivc gate scaling benchmark
0af0d22 
**Motivation**:
  To evaluate the performance scaling of two IVC schemes (Sangria and
  Cyclefold) with respect to the number of gates, we needed a dedicated
  benchmark.

**Overview**:
- Impl the `MultiStepCircuit`, which duplicates a simple Poseidon step circuit to simulate varying circuit sizes.
- Runs both Sangria and Cyclefold IVC schemes with fixed, hardcoded gate counts.
- Uses separate sets of gate counts for each scheme to capture their individual scaling behaviors.
@cyphersnake cyphersnake merged commit 21962ea into main Feb 26, 2025
1 of 2 checks passed
@cyphersnake cyphersnake deleted the refactor-examples branch February 26, 2025 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chaosma chaosma chaosma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cyphersnake cyphersnake

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyphersnake @chaosma