refactor(SnackGameBase): 핸들러를 객체로 묶어 GameScreen에 전달 #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 개요
📋 변경 및 추가 사항
기존에는 게임/아이템 처리 핸들러를 개별적으로 전달했는데, 객체로 묶어서 전달하도록 수정했습니다.
핸들러 변화가 생길 때마다 GameScreen 생성자 건드는 게 번거로웠읍니다
회의록에 정리할 때 쓴 사진이 있어서 첨부할게용
핸들러 타입을
handlers.type.ts에 정의하고SnackGameBase과GameScreen에서 사용합니다💬 To. 리뷰어