Emit log events as :warning instead of :warn#23
Open
jvf wants to merge 1 commit intosmpallen99:masterfrom
Open
Emit log events as :warning instead of :warn#23jvf wants to merge 1 commit intosmpallen99:masterfrom
jvf wants to merge 1 commit intosmpallen99:masterfrom
Conversation
harunzengin
approved these changes
Feb 7, 2024
Convert :warn to :warning to avoid getting a deprecation warning from Logger every time a :warning is emitted. The deprecation warning was added in Elixir v1.15.
ea61e4b to
cc8f647
Compare
harunzengin
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Elixir v1.15 a deprecation warning is emitted if the deprecated log level shortcut
warnis:At the same time the
Loggerpasses the log level aswarnto the old-style logger backends. Presumably for backwards compatibility. It thus falls to the logger backend to use the correct level identifier when emitting events.The
syslogbackend is such a logger backend. This PR adds a code snippet to transform the received levelwarntowarning.cc: @harunzengin @weisslj