Skip to content

Conversation

@smittrivedi
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, well-commented and thoughtful code, you are almost there!

Please make the following changes to complete the assignment:

  • For Part 1, Your function currently returns None. It should return True or False as requested.
  • For Part 2: It looks like your Part 2 function is the same as Part 1. The new is_case_sensitive parameter is a boolean. If it's true, we need to check whether the two words have the same letters and match in case. If it's false, we only care that the letters match, regardless of case. Could you give it another try? Let me know if you have any questions!

Quick reminder for future submissions (no need to address for completion of this assignment) — including a brief PR description is good practice, as it helps your "project-mate" quickly understand what’s going on.

Copy link

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments. Great work! Your assignment 1 is complete – no changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants