Conversation
added 3 commits
March 4, 2020 12:01
Update to babel 7's scoped packages and remove unneeded transform-object-rest-spread plugin
Remove compatibly issues with babel-polyfill, stop side-effects related to polluting global scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #317 first. Will be a much smaller changeset if that PR is merged.
Previously this library depended on a global polyfills (@babel/polyfill) to be compatible with older platforms (e.g. older browsers and node). Babel deprecated this strategy and encourages importing from
core-jsdirectly. Withbabel-preset-envpreset, we can automatically import the required polyfills with theuseBuiltinsoptions.For example previously we would get this as a babel output...
Now with the
useBuiltinsoption, our output looks like this:Including the polyfills in the library will increase the size, but solves issues with versions of
@babel/polyfilland other globals effecting this library. Another option would be to usebabel/runtime, but that would require changes to the consumers. See more details on the tradeoffs.