Add lodash as a peer dependency#318
Open
sfarthin wants to merge 2 commits intosmartprocure:masterfrom
Open
Conversation
added 2 commits
March 4, 2020 12:51
Since webpack does not bundle this dependency, the consumer is required to install lodash. Setting this as a peer dependency makes that more explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this package, consumers most likely already use lodash. Making lodash a peer dependency will make sure lodash is not duplicated when bundling JS for the client-side.
As a peer dependency, lodash will be automatically be installed (if not already) at the root level
node_moduessame asfutil-js.Note that the version is lenient so both
lodash 4.17.1andlodash 4.17.2get installed on the root. See Node.js docs for more information.