Fix invertByArray to treat keys as literals | issue #257#296
Open
jmm wants to merge 3 commits intosmartprocure:masterfrom
Open
Fix invertByArray to treat keys as literals | issue #257#296jmm wants to merge 3 commits intosmartprocure:masterfrom
invertByArray to treat keys as literals | issue #257#296jmm wants to merge 3 commits intosmartprocure:masterfrom
Conversation
Use `_.zipObject` instead of `zipObjectDeepWith` so path-like keys aren't interpreted as paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understand the intended usage correctly, this should fix #257. At any rate, the original tests pass with the change.
It seems that any path-like key is affected and it's not limited to keys with a leading
..