Fix UnregisterAppInterface for not found app#1572
Open
pvvasilev wants to merge 3 commits intosmartdevicelink:developfrom
pvvasilev:bugfix/unregister_app_interface_not_executing_for_unregistered_app
Open
Fix UnregisterAppInterface for not found app#1572pvvasilev wants to merge 3 commits intosmartdevicelink:developfrom pvvasilev:bugfix/unregister_app_interface_not_executing_for_unregistered_app
pvvasilev wants to merge 3 commits intosmartdevicelink:developfrom
pvvasilev:bugfix/unregister_app_interface_not_executing_for_unregistered_app
Conversation
If an app is not found in SDL but the mobile side sends UnregisterAppInterface, SDL creates the mobile request but never runs it because the app is not found. Then the request times out and the response to the mobile side is `GENERIC_ERROR`. Now command will be ran and the proper response of `APPLICATION_NOT_REGISTERED` will be sent.
Author
|
Please review @AKalinich-Luxoft @anosach-luxoft @VProdanov |
anosach-luxoft
approved these changes
May 29, 2017
| // RegisterAppInterface and UnregisterAppInterface should always be allowed | ||
| const mobile_apis::FunctionID::eType func_id = | ||
| static_cast<mobile_apis::FunctionID::eType>(function_id()); | ||
| if (mobile_apis::FunctionID::RegisterAppInterfaceID == func_id || |
Contributor
There was a problem hiding this comment.
@pvvasilev I propose you to use helpers::Compare here
ghost
approved these changes
May 29, 2017
AKalinich-Luxoft
approved these changes
May 29, 2017
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an app is not found in SDL but the mobile side
sends UnregisterAppInterface, SDL creates the mobile
request but never runs it because the app is not found.
Then the request times out and the response to the
mobile side is
GENERIC_ERROR. Now command will beran and the proper response of
APPLICATION_NOT_REGISTEREDwill be sent.