Fix IsReady acceptance after error response#1559
Open
VVeremjova wants to merge 2 commits intosmartdevicelink:developfrom
Open
Fix IsReady acceptance after error response#1559VVeremjova wants to merge 2 commits intosmartdevicelink:developfrom
VVeremjova wants to merge 2 commits intosmartdevicelink:developfrom
Conversation
Contributor
Author
|
@okozlovlux , @LitvinenkoIra Please review |
| static_cast<hmi_apis::Common_Result::eType>( | ||
| response_from_hmi[strings::params][hmi_response::code].asInt()); | ||
|
|
||
| bool is_successful_resultCode = |
There was a problem hiding this comment.
@VVeremjova , is_successful_result_code
kozlov-oleksandr
approved these changes
May 25, 2017
LitvinenkoIra
approved these changes
May 26, 2017
LuxoftAKutsan
approved these changes
May 29, 2017
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If result code from HMI on .IsReady is errorCode then SDL ) SDL should consider that works incorrectly and not available.