Fix detecting arhitecture on raspberry pi#1342
Merged
jacobkeeler merged 3 commits intosmartdevicelink:release/4.3.0from Mar 8, 2017
Merged
Fix detecting arhitecture on raspberry pi#1342jacobkeeler merged 3 commits intosmartdevicelink:release/4.3.0from
jacobkeeler merged 3 commits intosmartdevicelink:release/4.3.0from
Conversation
Detect arhotecture depending on size of void Related to smartdevicelink#1329
jacobkeeler
reviewed
Mar 2, 2017
| # void ptr = 4 byte --> x86 | ||
| set(${ARCH} "x86" PARENT_SCOPE) | ||
| elseif(ARCH_X64) | ||
| set(${ARCH} "x64" PARENT_SCOPE) |
Contributor
There was a problem hiding this comment.
@LuxoftAKutsan Do you know whether the change from x64 to x86_64 will break anything? From what I've seen of the CMake changes, it looks like this ARCH value is only really relevant when building for Windows.
jacobkeeler
reviewed
Mar 3, 2017
tools/cmake/helpers/platform.cmake
Outdated
| if(ARCH_X86) | ||
| if( CMAKE_SIZEOF_VOID_P MATCHES 8 ) | ||
| # void ptr = 8 byte --> x86_64 | ||
| set(${ARCH} "x86" PARENT_SCOPE) |
mrapitis
reviewed
Mar 6, 2017
Contributor
mrapitis
left a comment
mrapitis
left a comment
There was a problem hiding this comment.
using this branch, cmake process now succeeds and builds fine on raspberry pi
Contributor
Author
|
@mrapitis grate! @jacobkeeler @JackLivio please review and merge |
jacobkeeler
approved these changes
Mar 6, 2017
Contributor
|
I ran into the same "unsupported architecture" message when rebasing #1159 onto the new develop. Incorporating this fix resolved the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect architecture depending on size of void
Related to #1329