Skip to content

ATF Script for defect 1846#2120

Open
KrupenichOleg wants to merge 3 commits intodevelopfrom
defect_1846
Open

ATF Script for defect 1846#2120
KrupenichOleg wants to merge 3 commits intodevelopfrom
defect_1846

Conversation

@KrupenichOleg
Copy link
Contributor

@KrupenichOleg KrupenichOleg commented Oct 18, 2018 •
edited by GetmanetsIrina
Loading

ATF Test Scripts to check #1846

This PR is [ready] for review.

Summary

New ATF scripts to check the issue.

ATF version

develop

Changelog

  • New scripts
  • Added new script in the test set for the issues in the scope of 7.1 release

CLA

dboltovskyi
dboltovskyi suggested changes Oct 25, 2018
View reviewed changes
...scripts/Defects/5_0/1846_Mismatch_for_mandatory_parameter_between_MOBILE_API_and_HMI_API.lua Outdated
Copy link
Contributor

@dboltovskyi dboltovskyi Oct 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg Please update description in one of two ways:

  1. In case .... SDL does ...
  2. Steps ... Expected ...

Copy link
Contributor Author

@KrupenichOleg KrupenichOleg Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi Done in commit 20db55e. Also PTU added to preconditions.

...scripts/Defects/5_0/1846_Mismatch_for_mandatory_parameter_between_MOBILE_API_and_HMI_API.lua Outdated
Copy link
Contributor

@dboltovskyi dboltovskyi Oct 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg appID is not a part of parameters list for ShowConstantTBT in MOBILE API. Please notice list of parameters for MOBILE API could differ from list for HMI API

Copy link
Contributor

@dboltovskyi dboltovskyi Oct 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg The same in lines 45 and 50

@smartdevicelink smartdevicelink deleted a comment from dboltovskyi Oct 29, 2018
@KrupenichOleg KrupenichOleg changed the title ATF Script for Defect 1846 ATF Script for defect 1846 Oct 29, 2018
dboltovskyi
dboltovskyi suggested changes Oct 29, 2018
View reviewed changes
...scripts/Defects/5_0/1846_Mismatch_for_mandatory_parameter_between_MOBILE_API_and_HMI_API.lua Outdated
Copy link
Contributor

@dboltovskyi dboltovskyi Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg Please remove lines 7 through 12

...scripts/Defects/5_0/1846_Mismatch_for_mandatory_parameter_between_MOBILE_API_and_HMI_API.lua Outdated
Copy link
Contributor

@dboltovskyi dboltovskyi Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg Please add new line at the end of the script

...scripts/Defects/5_0/1846_Mismatch_for_mandatory_parameter_between_MOBILE_API_and_HMI_API.lua
local function checkShowConstantTBT(pParams, pResultTable)
local cid = common.getMobileSession():SendRPC("ShowConstantTBT", pParams)
common.getMobileSession():ExpectResponse(cid, pResultTable)
end
Copy link
Contributor

@dboltovskyi dboltovskyi Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrupenichOleg This steps are not enough for successful result. Please see full flow in https://github.com/smartdevicelink/sdl_atf_test_scripts/blob/develop/test_scripts/Smoke/API/016_ShowConstantTBT_PositiveCase_SUCCESS.lua

Copy link
Contributor Author

@KrupenichOleg KrupenichOleg Oct 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi all done in commit 1435755

@HSavynetska HSavynetska mentioned this pull request Nov 22, 2019
Open
@IGapchuk
Copy link
Contributor

IGapchuk commented May 25, 2020

PR is rebased on current develop(273b79d) branch.
The script is applicable to all policy flows and transport types.
Script has been moved to 6_1 folder.
The test set for the script is added.

@GetmanetsIrina
Copy link
Contributor

GetmanetsIrina commented Apr 6, 2021

The script is rebased on the actual develop branch (67f11b7)

@GetmanetsIrina GetmanetsIrina removed the request for review from HSavynetska April 6, 2021 12:19
Base automatically changed from develop to master April 14, 2021 16:06
@ShobhitAd ShobhitAd changed the base branch from master to develop April 14, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GetmanetsIrina GetmanetsIrina Awaiting requested review from GetmanetsIrina

2 more reviewers

@dboltovskyi dboltovskyi dboltovskyi approved these changes

@TMyza TMyza TMyza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KrupenichOleg @IGapchuk @GetmanetsIrina @dboltovskyi @TMyza

Comments