Fix/reset timeout for tts.speak#445
Closed
YuriiYefimenko wants to merge 5 commits intosmartdevicelink:release/0.11.0from
Closed
Fix/reset timeout for tts.speak#445YuriiYefimenko wants to merge 5 commits intosmartdevicelink:release/0.11.0from
YuriiYefimenko wants to merge 5 commits intosmartdevicelink:release/0.11.0from
Conversation
|
@YuriiYefimenko is this PR ready for Livio review? If so please advise if these bugs were introduced during the 0.11.0 testing? |
Contributor
Author
|
Hi @theresalech @jordynmackool This is a regression issue (related to OnResetTimeout feature) and PR is ready for Livio team review |
iCollin
reviewed
Sep 20, 2021
Co-authored-by: Collin <iCollin@users.noreply.github.com>
iCollin
reviewed
Sep 20, 2021
| this.playNext(); | ||
| if(!rpc.params.speakType.includes('ALERT')) | ||
| this.timers[rpc.id] = setInterval(this.onResetTimeout, 9000, rpc.params.appID, "TTS.Speak"); | ||
| this.timers[rpc.id] = setInterval(this.onResetTimeout, 9000, rpc.id); |
Collaborator
There was a problem hiding this comment.
Suggested change
| this.timers[rpc.id] = setInterval(this.onResetTimeout, 9000, rpc.id); | |
| if(!rpc.params.speakType.includes('ALERT')) | |
| this.timers[rpc.id] = setInterval(this.onResetTimeout, 9000, rpc.id); |
Collaborator
There was a problem hiding this comment.
@YuriiYefimenko we have closed #444, can you please make adjustments to ensure onResetTimeout is not sent when the TTS Speak is part of an Alert or AlertManeuver or apply the above suggestion? Thank you!
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#444
#442
Testing Plan
Summary
Bug Fixes
now HMI sends correct requestID in BC.OnResetTimeout for TTS.Speak request
CLA