Skip to content

Conversation

@flopezag
Copy link
Contributor

  • Aligned to 3.0.0
  • Correct some issues with the specification of DCAT-AP to transform links to Relationship
  • Fix the license values available
  • Update notes.yaml and README.md

Copy link
Contributor

@albertoabellagarcia albertoabellagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feernando. please check the comments sent internally

@bobeal
Copy link

bobeal commented Oct 23, 2024

Hi,

What's the status of this PR? May I help in some way (since I'm working on this with @flopezag in the WATERVERSE project)?

Copy link
Contributor

@albertoabellagarcia albertoabellagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attend the changes requested and pass the validator

Copy link
Contributor

@albertoabellagarcia albertoabellagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sent you the comment directly there are a couple of issues on both data models dataservice and dataservicerun

Copy link
Contributor

@albertoabellagarcia albertoabellagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have to test if our testing process can deal with languageproperties

@flopezag
Copy link
Contributor Author

Now we have to test if our testing process can deal with languageproperties

I suggest checking it in the new service deployed on fair-services.lab.fiware.org for DataService and Dataset.

Copy link
Contributor

@albertoabellagarcia albertoabellagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes are required, couple of errors

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is wrong (page 33 of the specification)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compression format property is represented by dcat:compressFormat in DCAT. I used the last one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong change packageFormat not packagingFormat (page 18 specification), same for compressionFormat. Rest of changes are ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem to compressionFormat. packaging format property is represented in dcat:packageFormat in DCAT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants