Fix: Preventing frequent double-pastes from IDE in Combobox

[alashchev17]

Fix: Preventing frequent double-pastes from IDE in Combobox

Description

• @file duplicates path

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactoring (no functional changes, only code improvements)
• Documentation update

How to Test

• Step 1: Type @file+Space
• Step 2: Paste path to file
• Step 3: Path should be inserted once

Checklist

• My code follows the code style of this project.
• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• Any dependent changes have been merged and published in downstream modules.
• I have updated the documentation where necessary.

[MarcMcIntosh]

Odd, onPaste isn't passed to the child component :/

[alashchev17]

Resolved

[MarcMcIntosh]

some characters have a length of more than 1

"🍆".length

[alashchev17]

We can compare in this case length of string itself, using Array.from(value).length

[alashchev17]

Made a fix by getting nativeEvent.inputType of event object in onChange handler, so then I can simply define if the event was insertFromPaste, or any of other input types which should be treated as paste event:

const isPasteEvent = [
  "insertFromPaste", 
  "insertFromDrop ", 
  "insertFromYank", 
  "insertReplacementText"
].includes(inputType)

[MarcMcIntosh]

Seems to work, I think this is re-occuring issue with vsode/

I think it would be easier to save event.nativeEvent.timeStamp on the paste events then use the difference between the timeStamp in the state and the event handleChange to decide to return early :)

Also remove console.log