Allow to construct a coil from an iterator #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abestanis
force-pushed
the
feature/from_iter
branch
from
5924a1d to
0a9448c
Compare
Abestanis
force-pushed
the
feature/from_iter
branch
from
0a9448c to
1825858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a usecase where I have an iterator that produces coils, and I want to avoid creating a temporary buffer when constructing the
Coilsobject for a response.To archive this, I had to change
modbus_core::pack_coilsto also accept an iterator, and I needed it to return the number of coils, not the number of bytes. Since the previous return type was the number of bytes as ausize, instead of using ausizeto represent the number of coils (thus potentially silently breaking code) I added a new typeCoilQuantitythat makes it clear what the number is used for.