Adding created_at and updated_at the application_resources#1
Open
Adding created_at and updated_at the application_resources#1
Conversation
This reverts commit 4027ab5.
…y#2109)" This reverts commit fd7bde4. The effects of this change were too widespread to be comfortable with. It makes sense to only request the larger page size where needed, as doing it by default seems to require a large number of test changes, and makes those tests more brittle - for instannce if we wanted to change the default in the future.
…dry#2111) These commands can potentially get a lot of data, and they are much faster if they get 5000 results per page, instead of the default of 50 per page. [#175715881](https://www.pivotaltracker.com/story/show/175715881)
…y#2115) In common with other V3 endpoints, the intention is for deleting a service to be recursive. The confirmation message in the CLI should reflect this. [#175741832](https://www.pivotaltracker.com/story/show/175741832)
ccv3.FeatureFlag and v7action.FeatureFlag to resources.FeatureFlag [#171119141] Authored-by: Sarah Weinstein <sweinstein@pivotal.io>
ccv3.Sidecar and v7action.Sidecar to resources.Sidecar [#171119141] Authored-by: Sarah Weinstein <sweinstein@pivotal.io>
Authored-by: Sarah Weinstein <sweinstein@pivotal.io>
[#175042021] Co-authored-by: Sarah Weinstein <sweinstein@pivotal.io> Co-authored-by: Teal Stannard <tstannard@pivotal.io>
On org creation, user roles are now assigned to the user creating the org as part of the org creation CAPI endpoint. We're fixing these integration tests to account for that change. [#175042021] Co-authored-by: Sarah Weinstein <sweinstein@pivotal.io> Co-authored-by: Teal Stannard <tstannard@pivotal.io>
Authored-by: Sarah Weinstein <sweinstein@pivotal.io>
ccv3.SpaceFeature to resources.SpaceFeature ccv3.Stack, v7action.Stack to resources.Stack [#171119141] Authored-by: Sarah Weinstein <sweinstein@pivotal.io>
Error: actor/v7action/stack.go Found unlinted files, please run 'make format' and push again. Authored-by: Sarah Weinstein <sweinstein@pivotal.io>
We use this tool as part of building binaries for each platform: https://github.com/akavel/rsrc We install it with a `go get` in our Makefile. In CI, building these binaries started failing with errors like `File 'rsrc.syso' not found`. It turns out that a recent change to rsrc changed the default name of the file that gets generated. It used to always default to `rsrc.syso`, but now it defaults to something like `rsrc_{OS}_{arch}.syso`. Fixing this by just explicitly passing `-o rsrc.syso` to rsrc, which will preserve the behavior we were already relying on: creating a file with the name `rsrc.syso`. Authored-by: Reid Mitchell <rmitchell@pivotal.io>
In the example the variable is called `p`, but the check is done on a non-existing field called `s`
It was broken also because it was an inline reference that we should have removed when we moved the version switching guide to it's own page.
In a certain random ordering, the "it does not return an error" test here would fail because the manifest had been set up to be invalid by a different test. With this change, making sure to initialize rawManifest to an empty byte array in a top-level BeforeEach to prevent test pollution.
- match the style of delete space - add that service instance will be unshared [#176115596](https://www.pivotaltracker.com/story/show/176115596) Co-authored-by: Marcela Campo <mcampo@pivotal.io>
We tried to change the PATCH /v3/service_broker endpoint to return HTTP 200 with no job when only the service broker name was being changed. However the CLI attempted to poll a non-existent job resulting in an error. When `PollJob()` is passed an empty job, it should simply return and not fail. [#169090128](https://www.pivotaltracker.com/story/show/169090128)
The issue that blocked this has now been resolved [#175573217](https://www.pivotaltracker.com/story/show/175573217)
* fix unit tests * update github runners to supported versions
* Combine chain of jobs into a single one This should help with rerunning integration tests in case of failure. It will claim, run integration tests, and unclaim in one transaction. * don't use shared values * add 3rd diego cell - rename test units workflow - rename checks for int workflow - TODO: commented out units runs * update units checkout v2 to v3 * update actions/checkout v2 to v3 * locally in the job: - use go mod to setup workers golang - parse build version out of BUILD_VERSION file TODO: move version to the build_data.yaml * Switch windows units to make * Skip k8s tests on Windows OS * import helpers --------- Co-authored-by: Benjamin Fuller <benjaminf@vmware.com> Co-authored-by: George Gelashvili <ggelashvili@vmware.com>
Bumps [sinatra](https://github.com/sinatra/sinatra) from 2.2.0 to 2.2.3. - [Changelog](https://github.com/sinatra/sinatra/blob/main/CHANGELOG.md) - [Commits](sinatra/sinatra@v2.2.0...v2.2.3) --- updated-dependencies: - dependency-name: sinatra dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
* Cleanup * Update dependabot.yml * Plugins to support v9 * Trigger units on new v* tag * Do not run the release pipeline on v8 tag
Bumps [github.com/google/go-querystring](https://github.com/google/go-querystring) from 0.0.0-20170111101155-53e6ce116135 to 1.1.0. - [Commits](https://github.com/google/go-querystring/commits/v1.1.0) --- updated-dependencies: - dependency-name: github.com/google/go-querystring dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.2.0 to 1.9.3. - [Release notes](https://github.com/sirupsen/logrus/releases) - [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md) - [Commits](sirupsen/logrus@v1.2.0...v1.9.3) --- updated-dependencies: - dependency-name: github.com/sirupsen/logrus dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.16.4 to 1.16.5. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v1.16.4...v1.16.5) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/kr/pty](https://github.com/kr/pty) from 1.1.1 to 1.1.8. - [Commits](kr/pty@v1.1.1...v1.1.8) --- updated-dependencies: - dependency-name: github.com/kr/pty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Capi team removed the AWS account and migrated their releases to a new location. Co-authored-by: Al Berez <aberezovsky@vmware.com>
Co-authored-by: Jhonathan Aristizabal <jhonathana@vmware.com> Co-authored-by: Pablo Rodas <prodas@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the CF CLI! Please read the following:
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Where this PR should be backported?
Description of the Change
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?