Fix: Bottom sheet appearing above navigation drawer (Issue #75) #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `usePopup` parameter to FlexibleSheetState that controls whether the bottom sheet renders in a popup window or inline within the composable hierarchy. When usePopup = true (default): The sheet uses a separate window via WindowManager, which renders above all content including navigation drawers. This is useful for overlaying content like Google Maps. When usePopup = false: The sheet renders inline, respecting the z-order of other components like ModalDrawer. This fixes issue skydoves#75 where the bottom sheet would appear above navigation drawers. Changes: - Add usePopup parameter to FlexibleSheetState (defaults to true for backward compatibility) - Update rememberFlexibleBottomSheetState to accept usePopup parameter - Update Saver to preserve usePopup across configuration changes - Modify FlexibleBottomSheet (Material) to conditionally render inline - Modify FlexibleBottomSheet (Material3) to conditionally render inline Fixes skydoves#75
Add ModalDrawer to MainActivity to test drawer layering behavior. Update sample sheets to use usePopup = false to demonstrate how the bottom sheet properly renders below the navigation drawer.
Add JVM unit tests that verify: - usePopup defaults to true for backward compatibility - usePopup can be explicitly set to false - usePopup can be explicitly set to true - usePopup is independent of isModal setting - FlexibleSheetSize default values are correct Tests run on JVM without requiring device or emulator.
Regenerate API signatures after adding usePopup parameter: - flexible-core: Add usePopup to FlexibleSheetState constructor and rememberFlexibleBottomSheetState function signature - app: Update lambda hashes reflecting demo app changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
usePopupparameter toFlexibleSheetStatethat controls whether the bottom sheet renders in a popup window or inline within the composable hierarchyusePopup = false, the bottom sheet renders inline, properly respecting the z-order of navigation drawerstruefor backward compatibilityProblem
The FlexibleBottomSheet was rendering above navigation drawers because it uses a popup window via
WindowManager. Any separate window will always appear above content in the parent window, regardless of the window type.Solution
Added an inline rendering mode that can be enabled by setting
usePopup = false:Trade-offs
usePopup = true(default)usePopup = falseTest plan
usePopup = truerenders above all content (default behavior unchanged)usePopup = falserenders below navigation drawerFixes #75