__start_on_boot: Speed up state explorer on OpenBSD #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of running `rcctl ls on` and grep(1)ing for the service of interest, we can just query the service's status. `rcctl ls on` does the same thing, but it queries the status for all services which is unnecessary for this case. Further, the grep(1) (which interpreted the service name as a regular expression) is not necessary anymore. Another issue with the grep was that it printed the service name if it matched, breaking `$state_is` in `manifest` and `gencode-remote`.
4nd3r
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of running
rcctl ls onand grep(1)ing for the service of interest, we can just query the service's status.rcctl ls ondoes the same thing, but it queries the status for all services which is unnecessary for this case.Further, the grep(1) (which interpreted the service name as a regular expression) is not necessary anymore. Another issue with the grep was that it printed the service name if it matched, breaking
$state_isinmanifestandgencode-remote.