Add Tests for aes encryption backend #422
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/docker-updates
hangouts is dead and Google is the prime suspect
…34 image from archive
Fix Travis CI
Fix slack pip install version condition (missing comma)
tests for plugin module
…lack Html link converter slack
Collaborator
|
What do you think about including test for exceptions? The unfortunate part is that the code uses the catch-all exception so we don't have a very precise way to test for that. |
Contributor
Author
|
@Ashex I could probably assert that the exception message was written to the log. Would that satisfy the case? |
Collaborator
|
The aim would be to increase test coverage, I think checking that it was written to the log may not increase coverage of the code in question since we want to test for the exception itself being thrown. But do correct me if I'm wrong. |
Contributor
Author
|
I meant if I force an exception by breaking it in the test, and then asserting the log was written it should execute the code. |
Collaborator
|
Okay understood, I think that would be a worthwhile test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two tests:
I would like to fix the pycrypto vulnerability as mentioned in #385
So I figured the first step is to add test coverage.