Skip to content

Conversation

@PoulavBhowmick03
Copy link

fixes #67

@ONEONUORA
Copy link
Contributor

Pls fmt and make the test to pass @PoulavBhowmick03

@PoulavBhowmick03
Copy link
Author

@ONEONUORA can you check now

@Abeeujah
Copy link
Contributor

Hi @PoulavBhowmick03 You should run cargo sqlx prepare This help cache your queries so it can be cross confirmed on CI

@Abeeujah
Copy link
Contributor

Hi @PoulavBhowmick03 there's already a validator profiles table in the migrations script, not sure why you're creating another one; Are you still working on this?

Copy link
Contributor

@Abeeujah Abeeujah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the rest of the modelling being built on the schema you provided for yourself, and no query caching to have these validated, I don't think there's much to be reviewed here though, we'd progress after the Schemas have been fixed


-- index for fast wallet lookups
CREATE INDEX IF NOT EXISTS idx_validators_wallet
ON validators(wallet_address);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PoulavBhowmick03 after going through the setup migration, anything particularly wrong with the validators table/schema in the migration script that spurred you to go ahead and create yours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validator Section

3 participants