Fix: Blender 4.2 compatibility by updating EEVEE engine detection#178
Open
kunaly111 wants to merge 5 commits intosketchfab:masterfrom
Open
Fix: Blender 4.2 compatibility by updating EEVEE engine detection#178kunaly111 wants to merge 5 commits intosketchfab:masterfrom
kunaly111 wants to merge 5 commits intosketchfab:masterfrom
Conversation
This pull request fixes Blender 4.2 compatibility for the Sketchfab Blender Plugin. The problem: - Blender 4.2 removed the old 'BLENDER_EEVEE' engine constant. - The plugin previously used 'BLENDER_EEVEE', which caused the addon to fail. The fix: - Detects available render engines dynamically. - Uses 'BLENDER_EEVEE_NEXT' if available, otherwise falls back to 'BLENDER_EEVEE'. - Ensures compatibility with Blender 3.x, 4.0, 4.1, and 4.2. - Prevents errors when setting the scene render engine. Tested: - Blender 4.2: addon installs, enables, and export panel works. - No errors in the console.
This pull request fixes Blender 4.2 compatibility for the Sketchfab Blender Plugin. The problem: - Blender 4.2 removed the old 'BLENDER_EEVEE' engine constant. - The plugin previously used 'BLENDER_EEVEE', which caused the addon to fail. The fix: - Detects available render engines dynamically. - Uses 'BLENDER_EEVEE_NEXT' if available, otherwise falls back to 'BLENDER_EEVEE'. - Ensures compatibility with Blender 3.x, 4.0, 4.1, and 4.2. - Prevents errors when setting the scene render engine. Tested: - Blender 4.2: addon installs, enables, and export panel works. - No errors in the console. Fixes issue: sketchfab#141
This pull request fixes Blender 4.2 compatibility for the Sketchfab Blender Plugin. The problem: - Blender 4.2 removed the old 'BLENDER_EEVEE' engine constant. - The plugin previously used 'BLENDER_EEVEE', which caused the addon to fail. The fix: - Detects available render engines dynamically. - Uses 'BLENDER_EEVEE_NEXT' if available, otherwise falls back to 'BLENDER_EEVEE'. - Ensures compatibility with Blender 3.x, 4.0, 4.1, and 4.2. - Prevents errors when setting the scene render engine. Tested: - Blender 4.2: addon installs, enables, and export panel works. - No errors in the console. Fixes issue: sketchfab#141
|
Works just fine, thanks! |
Author
Thanks for testing and confirming ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes Blender 4.2 compatibility for the Sketchfab Blender Plugin.
The problem:
The fix:
Tested:
Fixes issue: #141