-
-
Notifications
You must be signed in to change notification settings - Fork 5
chore(deps): update SQLite from 3.50.2 to 3.50.4 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe CMake configuration was updated to reference SQLite3 version 3.50.4 (was 3.50.2): version string, download URL for the SQLite amalgamation archive, and SHA3-256 checksum were replaced. No other build logic, options, or targets were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CMakeLists.txt (1)
3-4: Hard-coded year path & numeric suffix invite future drift
The download URL embeds both the release year (2025) and the numeric build suffix (3500400). Next time the version is bumped, both pieces must be remembered and updated manually. Consider centralising those values or deriving them fromSQLITE3_VERSIONto reduce human error.Example refactor:
-# 3.50.4 → 3500400 (major 3, minor 50, patch 4, each two-digit) -set(SQLITE3_DOWNLOAD_URL "https://sqlite.org/2025/sqlite-amalgamation-3500400.zip") +set(SQLITE3_YEAR "2025") # keep near a single place +# FIXME: derive automatically to avoid mistakes +set(SQLITE3_NUM_SUFFIX "3500400") +set(SQLITE3_DOWNLOAD_URL + "https://sqlite.org/${SQLITE3_YEAR}/sqlite-amalgamation-${SQLITE3_NUM_SUFFIX}.zip")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CMakeLists.txt(1 hunks)
🔇 Additional comments (1)
CMakeLists.txt (1)
5-5: ✅ SHA3-256 checksum verified
The downloadedsqlite-amalgamation-3500400.ziparchive matches the declared SHA3-256 hash (f131b68e6ba5fb891cc13ebb5ff9555054c77294cb92d8d1268bad5dba4fa2a1), so the checksum in CMakeLists.txt is correct.
6cf8a72 to
6a11a93
Compare
This PR updates SQLite from 3.50.2 to 3.50.4.