Skip to content

Conversation

@sjinks
Copy link
Owner

@sjinks sjinks commented Jul 31, 2025

This PR updates SQLite from 3.50.2 to 3.50.4.

@coderabbitai
Copy link

coderabbitai bot commented Jul 31, 2025

Walkthrough

The CMake configuration was updated to reference SQLite3 version 3.50.4 (was 3.50.2): version string, download URL for the SQLite amalgamation archive, and SHA3-256 checksum were replaced. No other build logic, options, or targets were changed.

Changes

Cohort / File(s) Change Summary
CMake SQLite Version Update
CMakeLists.txt
Updated SQLite3 version from 3.50.2 to 3.50.4; replaced download URL and SHA3-256 checksum to match the new archive.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop and a skip, a version anew,
SQLite’s number has grown by two.
The CMake patch, precise and tight,
Points to a source both new and right.
Hashes match and builds take wing — hooray! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6cf8a72 and 6a11a93.

📒 Files selected for processing (1)
  • CMakeLists.txt (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • CMakeLists.txt
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-sqlite-3.50.4

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CMakeLists.txt (1)

3-4: Hard-coded year path & numeric suffix invite future drift
The download URL embeds both the release year (2025) and the numeric build suffix (3500400). Next time the version is bumped, both pieces must be remembered and updated manually. Consider centralising those values or deriving them from SQLITE3_VERSION to reduce human error.

Example refactor:

-# 3.50.4  →  3500400  (major 3, minor 50, patch 4, each two-digit)
-set(SQLITE3_DOWNLOAD_URL "https://sqlite.org/2025/sqlite-amalgamation-3500400.zip")
+set(SQLITE3_YEAR "2025")                                    # keep near a single place
+# FIXME: derive automatically to avoid mistakes
+set(SQLITE3_NUM_SUFFIX "3500400")
+set(SQLITE3_DOWNLOAD_URL
+    "https://sqlite.org/${SQLITE3_YEAR}/sqlite-amalgamation-${SQLITE3_NUM_SUFFIX}.zip")
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82c0fb5 and 6cf8a72.

📒 Files selected for processing (1)
  • CMakeLists.txt (1 hunks)
🔇 Additional comments (1)
CMakeLists.txt (1)

5-5: ✅ SHA3-256 checksum verified
The downloaded sqlite-amalgamation-3500400.zip archive matches the declared SHA3-256 hash (f131b68e6ba5fb891cc13ebb5ff9555054c77294cb92d8d1268bad5dba4fa2a1), so the checksum in CMakeLists.txt is correct.

@sjinks sjinks force-pushed the update-sqlite-3.50.4 branch from 6cf8a72 to 6a11a93 Compare August 12, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants