Refactor for win32 loader #4
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivileri
commented
Feb 3, 2023
jenatali
approved these changes
Feb 3, 2023
sivileri
force-pushed
the
win32_loader
branch
11 times, most recently
from
b086760 to
0e1502e
Compare
…loading - Split va_OpenDriver into va_OpenDriverFromPath and va_OpenDriverFromName to allow for absolute path driver loading and separate the dlopen logic from the possible paths calculation and iteration - Add new backend function vaGetDriverPathByIndex for driver candidate loading by absolute path - Rename va_getDriverNameByIndex to va_getDriverCandidateByIndex which will now get the driver name or path from the backend. - Rewrite va_openDriver which will now attempt to load the driver from the usual previous driver name and path construction process or use the new absolute path loading mechanism with or without LIBVA_DRIVERS_PATH env variable override. - Add extra attempt to load driver in va_OpenDriver without the drv_video suffix (win32 backend will need this) The two ways with/without suffix is for apps backward compatibility Signed-off-by: Sil Vilerino <sivileri@microsoft.com>
- Implement vaGetDriverPathByIndex instead of vaGetDriverNameByIndex - Provide a default driver name to avoid having to always set LIBVA_DRIVERS_PATH on Windows Signed-off-by: Sil Vilerino <sivileri@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.