-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/pro 4276 AR #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
R-lagoman
wants to merge
10
commits into
develop
Choose a base branch
from
feature/PRO-4276-ar
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/pro 4276 AR #572
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d155f71
Add internal callback to receive MapView messages
R-lagoman 7026bae
Change version to beta.0
R-lagoman 8f778ff
Add new callback with useImperativeHandle instead of props
R-lagoman 2c25ab8
Update version to beta.1
R-lagoman ea573d0
Merge branch 'develop' into feature/PRO-4276-ar
R-lagoman 845abe9
feat: send deviceId on map-is-ready.
R-lagoman aa90665
docs: Update CHANGELOG_UNRELEASED
R-lagoman e77418d
refactor: restore version
R-lagoman 45b2099
refactor: Rename callback
R-lagoman d5ba525
refactor: Internal callback now lives behind internal interface
R-lagoman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| ### Added | ||
|
|
||
| - We have added `SitumProvider.apiDomain`. This parameter is useful only in certain scenarios where configuring the Situm's environment is neccessary. | ||
| - Added a new callback `onInternalMapViewMessageCallback` invoked with every MapView message. | ||
| It is used internally — no action is required on your side. | ||
|
|
||
| ### Changed | ||
|
|
||
| - We have simplified the autenthication process of our plugin. Use SitumProvider at the root of your app to initialize & set your `SitumProvider.apiKey`. Now this step will prevent you from calling `SitumPlugin.init()` and `SitumPlugin.setApiKey()` methods, and from specifying the `MapViewConfiguration.situmApiKey` to display our map. | ||
| - Example app: we have now simplified the authentication process in our example app, using the new `SitumProvider.apiKey`. | ||
| - Made WebView message handling more robust with guarded JSON parsing and default fallbacks for | ||
| type and payload. This is also an internal change that requires no action on your side. | ||
| - Now the MapView receives the `deviceId` from the underlying SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Este método parece que estaba implementado, pero non estaba na interface... TS colaba igual...