Skip to content

Conversation

@td2thinh
Copy link
Contributor

@td2thinh td2thinh commented Jun 3, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • The tool didn't work on my Mac Sequoia machine and after looking around the repo and online, I found that it happens to be an issue with ipv6. dummynet when used implicitly will only match ipv4 (this needs to be confirmed).

Related Tickets & Documents

Proposed Changes:

  • Add ipv6 specific dummynet commands

DISCLAIMER

Modifications were done with the help of Deepseek Reasoning LLM model. Probably needing more reviews but after the changes, it works under my machine.

@soulgalore
Copy link
Member

Hi @td2thinh thank you and +++ for adding the disclaimer. I'll test it one of the coming days. Can you please fix the linting error (npm run lint:fix). Thank you!

@td2thinh
Copy link
Contributor Author

td2thinh commented Jun 3, 2025

I fixed the lint issues. I thought husky would launch lint:fix pre-commit but I guess that needs to be configured first xD.

@soulgalore soulgalore merged commit 4e762e2 into sitespeedio:main Jun 5, 2025
5 of 6 checks passed
@soulgalore
Copy link
Member

Thank you @td2thinh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants