-
Notifications
You must be signed in to change notification settings - Fork 1
Add 'metrics' flag to specify available metrics #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@soulgalore Hey!) This is a PR about we discussed several days ago. |
|
Looks good. I have two suggestions:
|
|
9477c67 to
e35b26f
Compare
|
|
Sorry, I have a concern about Linux. Should I add just another step with the filter by functions? And then it will be check manually in InfluxDB? I'm just worried that the previous step with all functions will mislead the check results. |
|
I didn't fully understand the concern about Linux? One thing you could do is in the "open" function https://github.com/sitespeedio/plugin-influxdb/blob/main/lib/index.js#L20 (that is called on startup) you could verify the input of influxdb.functions and if something is broken or wrong log or throw an error before the tests start? |
|
Copy that, I'll get it done |
|
@soulgalore Let's run the workflow) |
|
Thank you @Amerousful , I'll release this first thing tomorrow. |
|
@soulgalore Thank you too) Deal. |
New flag to control list of available metrics due to reduce metric data size