Skip to content

Allow publishable fields to be disabled not only by abilities but also by option #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zanetagebka wants to merge 1 commit into
base: v7
Choose a base branch
from
Open

Allow publishable fields to be disabled not only by abilities but also by option #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/cells/folio/console/publishable_inputs/item/show.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ div class=class_name data=data
= f.input field,
hint: false,
as: :boolean,
disabled: read_only?,
disabled: disabled?,
input_html: input_html('checkbox', checkbox: true),
wrapper_html: { class: 'f-c-publishable-inputs-item__group' },
atom_setting: model[:atom_setting] == false ? nil : field
Expand All @@ -13,7 +13,7 @@ div class=class_name data=data
= f.input "#{field}_at",
label: false,
hint: false,
disabled: read_only?,
disabled: disabled?,
wrapper_html:,
input_html: input_html('input', placeholder: t('.at')),
atom_setting: model[:atom_setting] == false ? nil : "#{field}_at"
Expand All @@ -23,15 +23,15 @@ div class=class_name data=data
= f.input "#{field}_from",
label: false,
hint: false,
disabled: read_only?,
disabled: disabled?,
wrapper_html:,
input_html: input_html('input', placeholder: t('.from')),
atom_setting: model[:atom_setting] == false ? nil : "#{field}_from"

= f.input "#{field}_until",
label: false,
hint: false,
disabled: read_only?,
disabled: disabled?,
wrapper_html:,
input_html: input_html('input', placeholder: t('.to')),
atom_setting: model[:atom_setting] == false ? nil : "#{field}_until"
Expand Down
4 changes: 4 additions & 0 deletions app/cells/folio/console/publishable_inputs/item_cell.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ def read_only?
@read_only
end

def disabled?
model[:disabled] || read_only?
end

def date_at?
return @date_at unless @date_at.nil?
@date_at = f.object.respond_to?("#{field}_at")
Expand Down
7 changes: 4 additions & 3 deletions app/cells/folio/console/publishable_inputs/show.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.f-c-publishable-inputs class=options[:class_name]
- fields.each do |field|
- fields.each do |field_config|
- field_name = field_config.is_a?(Hash) ? field_config[:field] : field_config
- field_disabled = field_config.is_a?(Hash) ? field_config[:disabled] : nil
== cell('folio/console/publishable_inputs/item',
f:,
field:,
{ f:, field: field_name, disabled: field_disabled },
atom_setting: options[:atom_setting])
3 changes: 2 additions & 1 deletion app/cells/folio/console/publishable_inputs_cell.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ def fields
ary += options[:additional_fields] if options[:additional_fields]

ary.filter do |field|
f.object.respond_to?(field)
field_name = field.is_a?(Hash) ? field[:field] : field
f.object.respond_to?(field_name)
end
end
end
Expand Down