Skip to content

Conversation

@bunysae
Copy link
Contributor

@bunysae bunysae commented Sep 3, 2019

Fixes #79 the gpg-password-prompt is gobbled. The listr-task "Bumping version using npm" gets a suspend-flag, which stops the listr-update-renderer.

In order to get this solution working, there are same changes necessary at listr and listr-update-renderer.
The pull-requests for this changes can be found at the following links:

Testing this pull-request requires the following client-setup:

  1. create a gpg-key-pair with the command gpg --generate-key
  2. set this key as default key for commit-signing with the command git config --set --global user.signingkey <KEY>
  3. activate commit-signing:
  • for npm with the command npm config set sign-git-commit true or
  • for yarn with the command yarn config set version-sign-git-tag true

IssueHunt Summary

@sindresorhus
Copy link
Owner

The pull-requests for this changes are currently open.

Can you link to those pull requests?

@sindresorhus
Copy link
Owner

What about Yarn? Look at the task above the one you modified.

@sindresorhus
Copy link
Owner

Can you give the PR a better title?

@bunysae bunysae changed the title solution for issue #79 gpg-password-prompt Support all kinds of gpg-password-prompts (see issue #79) Sep 14, 2019
@sindresorhus sindresorhus changed the title Support all kinds of gpg-password-prompts (see issue #79) Support GPG password prompt Sep 14, 2019
@bunysae
Copy link
Contributor Author

bunysae commented Sep 14, 2019

When using yarn, the gpg-password-prompt was also gobbled. I fixed it with the last commits.

This was referenced Feb 17, 2020
@sindresorhus
Copy link
Owner

Can you mention this feature in the readme?

@bunysae
Copy link
Contributor Author

bunysae commented Jul 18, 2020

Can you mention this feature in the readme?

It's mentioned.

Base automatically changed from master to main January 23, 2021 17:55
@sindresorhus
Copy link
Owner

Maybe we could move this forward by retargeting your PRs to https://github.com/cenk1cenk2/listr2 and then move to listr2 in np.

bunysae added a commit to bunysae/np that referenced this pull request Jun 16, 2021
@bunysae bunysae closed this Jun 16, 2021
bunysae added a commit to bunysae/np that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support GPG password prompt

2 participants