Open
Conversation
|
Visit the preview URL for this PR (updated for commit 9823028): https://moringa-library--pr71-dachoka3000-search-u-4mk4f6js.web.app (expires Thu, 30 Mar 2023 08:12:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 28c4ac8715d663d94559951bf1a9d3f1dcb7979f |
…/sinatra-pod/moringa-library into Dachoka3000/search-user-endpoint
…/sinatra-pod/moringa-library into Dachoka3000/search-user-endpoint
otsembo
requested changes
Mar 23, 2023
| source 'https://rubygems.org/' | ||
|
|
||
| ruby File.read('.ruby-version').strip | ||
| # ruby File.read('.ruby-version').strip |
Comment on lines
+5
to
+6
| # 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 | ||
| # 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 |
Contributor
There was a problem hiding this comment.
Remove sendgrid secret keys from version control
Comment on lines
+9
to
+10
| from = SendGrid::Email.new(email: 'albert.byrone@moringaschool.com', name: 'Moringa Hub') | ||
| to = SendGrid::Email.new(email: user.email, name: user.name) |
Contributor
There was a problem hiding this comment.
Create SendGrid account with sinatra pod email.
Add email to .env. DO NOT hard code.
| @@ -1,4 +1,4 @@ | |||
| ENV["RACK_ENV"] ||= "development" | |||
| ENV["RACK_ENV"] ||= "test" | |||
Contributor
There was a problem hiding this comment.
Change default environment to development.
Contributor
There was a problem hiding this comment.
Remove sqlite db from version control
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.