pykson: Check if attribute is a JsonObject for ObjectListField#18
Open
patrickelectric wants to merge 1 commit intosinarezaei:masterfrom
Open
pykson: Check if attribute is a JsonObject for ObjectListField#18patrickelectric wants to merge 1 commit intosinarezaei:masterfrom
patrickelectric wants to merge 1 commit intosinarezaei:masterfrom
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Owner
|
I don't understand the usecase for JsonObject, why shouldn't one use the ObjectField? |
Author
On our tests, it fail to deserialize nested/deep jsonobjects, it was necessary to check, otherwise it detects it as a dict. I'm in the middle of a vacation right now, but you can check the others PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick José Pereira patrickelectric@gmail.com