Skip to content

Conversation

@eliasto
Copy link

@eliasto eliasto commented Dec 17, 2025

Summary

Hi team,
This PR adds a new block for OVHcloud AI Endpoints, the inference provider of OVHcloud, the leading Cloud Provider in Europe.

It also adds documentation, and edit the Hugging Face block to add OVHcloud AI Endpoints.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

A workflow has been created to test if the two block are functioning properly.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Screenshot 2025-12-17 at 14 05 01 Screenshot 2025-12-17 at 14 05 32

@vercel
Copy link

vercel bot commented Dec 17, 2025

@eliasto is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 17, 2025

Greptile Summary

Added OVHcloud AI Endpoints integration with chat and embeddings capabilities. Implementation follows codebase patterns and includes comprehensive documentation in English and French.

Key Changes:

  • New ovhcloud block with dual operations (chat/embeddings) using conditional inputs
  • Two new tools: ovhcloud_chat and ovhcloud_embeddings with OpenAI-compatible API endpoints
  • Integrated OVHcloud as provider option in Hugging Face block
  • Icon components and UI integrations across docs and landing pages
  • Complete documentation with API details and usage instructions

Critical Issue:

  • apps/sim/tools/ovhcloud/embeddings.ts missing input parameter definition in params object (lines 10-22), will cause runtime error when embeddings operation is used

Confidence Score: 3/5

  • Critical bug in embeddings tool will cause runtime failure; chat functionality appears safe
  • The missing input parameter in embeddings.ts is a critical syntax error that will prevent the embeddings feature from working. While the chat implementation is solid and documentation is thorough, this bug must be fixed before merge
  • Pay close attention to apps/sim/tools/ovhcloud/embeddings.ts - requires immediate fix for missing parameter definition

Important Files Changed

Filename Overview
apps/sim/tools/ovhcloud/embeddings.ts Missing input parameter definition causing runtime error; output type mismatch (string vs array)
apps/sim/tools/ovhcloud/chat.ts Well-implemented chat tool following codebase patterns correctly
apps/sim/blocks/blocks/ovhcloud.ts Block configuration correctly maps operations to tools with proper conditional inputs
apps/sim/blocks/registry.ts Added OVHcloud block to registry in alphabetical order
apps/sim/tools/registry.ts Registered both OVHcloud tools at end of registry

Sequence Diagram

sequenceDiagram
    participant User
    participant SimUI as Sim UI/Block
    participant OVHBlock as OVHcloud Block
    participant ToolRegistry as Tool Registry
    participant OVHChat as ovhcloud_chat Tool
    participant OVHEmbed as ovhcloud_embeddings Tool
    participant API as OVHcloud API Endpoints

    User->>SimUI: Select OVHcloud AI Endpoints block
    SimUI->>OVHBlock: Load block configuration
    OVHBlock->>SimUI: Display operation dropdown (Chat/Embeddings)
    
    alt Chat Operation
        User->>SimUI: Select Chat, enter prompt & model
        SimUI->>OVHBlock: params.operation = 'ovhcloud_chat'
        OVHBlock->>ToolRegistry: Get ovhcloud_chat tool
        ToolRegistry->>OVHChat: Execute with params
        OVHChat->>API: POST /v1/chat/completions
        API-->>OVHChat: Return completion response
        OVHChat-->>SimUI: Return {content, model, usage}
    else Embeddings Operation
        User->>SimUI: Select Embeddings, enter input text & model
        SimUI->>OVHBlock: params.operation = 'ovhcloud_embeddings'
        OVHBlock->>ToolRegistry: Get ovhcloud_embeddings tool
        ToolRegistry->>OVHEmbed: Execute with params
        OVHEmbed->>API: POST /v1/embeddings
        API-->>OVHEmbed: Return embeddings response
        OVHEmbed-->>SimUI: Return {embedding, model, usage}
    end
    
    SimUI->>User: Display results
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (2)

  1. apps/sim/tools/ovhcloud/embeddings.ts, line 10-22 (link)

    syntax: missing input parameter definition in params object - defined in OVHcloudEmbeddingsParams interface and used at line 35, but not declared here

  2. apps/sim/tools/ovhcloud/embeddings.ts, line 59 (link)

    syntax: output type mismatch - should be array not string since embedding is number[]

20 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@eliasto eliasto force-pushed the add-ovhcloud-ai-endpoints-provider branch from 4519cd1 to f028a0b Compare December 17, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant