-
Notifications
You must be signed in to change notification settings - Fork 3k
feat: add Google Drive Get File and Notion Create Page in Database Operations #2022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@naaa760 is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
Greptile Summary
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Workflow
participant GoogleDrive
participant NotionDB
User->>Workflow: Trigger workflow
Workflow->>GoogleDrive: Get File operation
GoogleDrive-->>Workflow: Return file content
Workflow->>NotionDB: Create Page in Database
NotionDB-->>Workflow: Page created
Workflow-->>User: Workflow complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
apps/sim/tools/notion/create_page.ts, line 78-94 (link)logic: when creating a page in a database (parentType is
database_id), the title property may not be named "title" - databases can have different property names for their title column (e.g., "Name", "Task", etc.). This assumes the title property is always named "title", which is only true for regular pages.Check the database schema first to get the correct title property name, or allow the user to specify which property should receive the title value.
4 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
LIHUA919
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| mode: 'advanced', | ||
| condition: { field: 'operation', value: 'get_content' }, | ||
| }, | ||
| // Export format for Google Workspace files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropdown operation: thêm mục { label: 'Get File', id: 'get_content' }.
UI fields (thay thế khối comment cũ):
fileSelector (mode: "basic"): một file-selector cho Google Drive,
canonicalParamId: 'fileId' — map giá trị đã chọn về tham số runtime fileId,
provider/serviceId: 'google-drive',
requiredScopes: thêm các scope OAuth ['drive.readonly','drive.file'],
dependsOn: ['credential'], placeholder, condition: chỉ hiển thị khi operation === 'get_content', required: true.
manualFileId (mode: "advanced"): input kiểu short-input, canonicalParamId: 'fileId', để nhập ID thủ công khi cần (chỉ hiển thị cho operation === 'get_content').
mimeType: dropdown xuất khẩu được mở rộng (thêm PDF và Microsoft Word MIME type) và vẫn chỉ hiện cho operation === 'get_content'.
tools.access: thêm 'google_drive_get_content' vào danh sách quyền công cụ.
tools.config.tool: thêm case 'get_content' => 'google_drive_get_content' để ánh xạ thao tác mới sang tool tương ứng.
inputs: thêm schema input fileId: { type: 'string', description: 'File identifier for get_content operation' }.
Summary
fix: #1939
Type of Change
Testing
Checklist