Dynamic Path for LogoHeader + copy icon image #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copy icon is broken (if you didn't with theme name "pear" or when it's not installed in first level).
Therefore, i made the image path dynamically according to the theme path.
in loop-single.php
/ /Line 36
<img src="<?php bloginfo('template_directory'); ?>/images/icon-copy.png" title="" alt="copy" />
// Line 43
<img src="<?php bloginfo('template_directory'); ?>/images/icon-copy.png" title="" alt="copy" />
Signed-off-by: Danny Chang <me@imdanny.com>
The current link will not work if you have pears installed in a sub-folder in custom domain. The fix is using standard wp veritable to define the path. Signed-off-by: Danny Chang <me@imdanny.com>
|
@simplebits we really need this change. please merge this two commits |
simplebits
added a commit
that referenced
this pull request
Mar 8, 2012
Dynamic Path for LogoHeader + copy icon image
Owner
|
Done! |
|
thanks ! |
|
I made a pull request (#28) to wrap up this issue. The footer logo was left out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Therefore, i made the image path dynamically according to the theme path.