Skip to content

Cleanup for rubocop #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silug merged 8 commits into from
Jan 5, 2026
Merged

Cleanup for rubocop #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bcca60c
Cleanup for rubocop
silug Sep 17, 2025
955f962
Allow puppet 7 gem
silug Sep 17, 2025
3b2db81
Additional cleanup and bump version
silug Sep 17, 2025
25c0b8f
Formatting fixes
silug Sep 17, 2025
91f977f
Additional fixes
silug Sep 17, 2025
57c0c31
Switch from createrepo to createrepo_c
silug Sep 18, 2025
b4246ba
Update to latest rubocop
silug Dec 15, 2025
2454c81
Additional cleanup
silug Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/pr_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,25 @@ on:

jobs:
ruby-style:
if: false # TODO Modules will need: rubocop in Gemfile, .rubocop.yml
name: 'Ruby Style (experimental)'
name: 'Ruby Style'
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v6
- name: "Install Ruby ${{matrix.puppet.ruby_version}}"
- name: "Install Ruby 2.7"
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7.8
bundler-cache: true
- run: |
bundle show
bundle exec rake rubocop
bundle exec rubocop
releng-checks:
name: 'RELENG checks'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- name: 'Install Ruby ${{matrix.puppet.ruby_version}}'
- name: 'Install Ruby 2.7'
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7.8
Expand Down Expand Up @@ -76,7 +75,7 @@ jobs:
# unit test uses mkisofs and rpmbuild
- run: 'command -v mkisofs || if command -v apt-get; then sudo apt-get update; sudo apt-get install -y genisoimage; fi ||:'
- run: 'command -v rpmbuild || if command -v apt-get; then sudo apt-get update; sudo apt-get install -y rpm-build; fi ||:'
- run: 'command -v createrepo || if command -v apt-get; then sudo apt-get update; sudo apt-get install -y createrepo; fi ||:'
- run: 'command -v createrepo_c || if command -v apt-get; then sudo apt-get update; sudo apt-get install -y createrepo-c; fi ||:'
- run: 'bundle exec rake spec'

# dump_contexts:
Expand Down
Loading