Fix issue #20 #22
Open
Fix issue #20 #22
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttok is showing a UserWarning coming from the click library reporting that --tokens is used more than once:
$ ttok --version
/Users/brian/.pyenv/versions/3.13.3/envs/llm-dev-3.13/lib/python3.13/site-packages/click/core.py:1193: UserWarning: The parameter --tokens is used more than once. Remove its duplicate as parameters should be unique.
parser = self.make_parser(ctx)
/Users/brian/.pyenv/versions/3.13.3/envs/llm-dev-3.13/lib/python3.13/site-packages/click/core.py:1186: UserWarning: The parameter --tokens is used more than once. Remove its duplicate as parameters should be unique.
self.parse_args(ctx, args)
ttok, version 0.3
# What I think is the root cause
Click is generating this warning because the parameter `--tokens` has been registered for two **different** actions (`encode_tokens` and `as_tokens`):
```
@click.option("encode_tokens", "--encode", "--tokens", is_flag=True, help="Output token integers")
@click.option("as_tokens", "--tokens", is_flag=True, help="Output full tokens")
```
Based on the examples from the help `--tokens` behavior aligns with `as_tokens`(_Output full tokens_) and not with that of `encode_tokens` (_Output token integers_) so we should remove `--tokens` from `click.option("encode_tokens"`
Here's the help:
>To view token integers:
>
> cat input.txt | ttok --encode
>
>[...]
>To see the details of the tokens:
>
> ttok "hello world" --tokens
>
> Outputs:
>
> [b'hello', b' world']
>
Author
|
Side note: Gemini Pro 2.5 detected the root cause of the issue (I just pasted the warning to it with nothing else) and ChatGPT helped me propose a sane fix. I was the chief editor :-D |
|
@simonw Can we please get this merged? Thanks! |
neko1990
added a commit
to neko1990/ttok
that referenced
this pull request
Dec 26, 2025
pull change from simonw#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ttok is showing a UserWarning coming from the click library reporting that --tokens is used more than once:
What I think is the root cause
Click is generating this warning because the parameter
--tokenshas been registered for these two different actions:Based on the examples from the help, the behavior of
--tokensaligns with the second action ("Output full tokens") and does not align with the first one ("Output token integers"). Thus we should remove--tokensfrom the first one.Here's the help:
P.S.
Simon, many thanks for the tools and your excellent blog