Open
Conversation
BrianJKoopman
requested changes
Dec 20, 2024
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Thanks for the PR! I'll wait for simonsobs/socs#787 to be resolved and merged. In the meantime a couple of comments below.
|
|
||
|
|
||
| def stop(active=True, brake_voltage=None): | ||
| def stop(active=True, brake_voltage=None, fast=False): |
Member
There was a problem hiding this comment.
Please add the new fast argument to the docstring.
Member
There was a problem hiding this comment.
You may have noticed the failing tests in the checks. Two tests in test_hwp.py are failing. These should be modified to handle cases for the new fast argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fast brake option in this PR is related to #179.
WG team is trying to measure the time constant by changing the hwp frequency rapidly e.g. +2Hz to -2Hz.
Current brake command is designed for gentle spindown and it takes >10 min to start inverse rotation.
New option of brake command is expected to take <2 min to spindown.
https://docs.google.com/presentation/d/1-kgAFn2sVR3R_Hp8_HcEYgZ8_SoNihm-UwsMn-Skxto/edit?usp=sharing
The modification in
hwp_supervisoris discussed in PR #787 in socs.This PR should be merged after the hwp_supervisor change is approved.