Remove logging of every bias step.

[tristpinsm]

During my SMuRF tsar shift I noticed that the logs in the pysmurf controllers were often hard to read due to their volume and the mix of sodetlib / pysmurf / other origins that were sometimes conflicting. I think there might be some improvement possible on the pysmurf side, so I'll create an issue there.

This was one particularly egregious example.

[msilvafe]

I looked into the smurf logger class and couldn't tell exactly how the log verbosity works but do you think it's possible to log this at a higher log level like "debug" in a standard python logger instead of deleting it directly?

[tristpinsm]

Yeah, it's not super easy to find, but the log verbosity is defined here. It looks like by default it logs at level 0 (least verbose).

So I could set it to LOG_INFO (1), which (should) suppress these in the pysmurf_controller logs. But to confirm I'd have to test it out I think.

[msilvafe]

Yeah, it's not super easy to find, but the log verbosity is defined here. It looks like by default it logs at level 0 (least verbose).

So I could set it to LOG_INFO (1), which (should) suppress these in the pysmurf_controller logs. But to confirm I'd have to test it out I think.

Ok, is this something your could test on the slac system?

[tristpinsm]

what would be easy to do is put in some log statements and play with the verbosity to confirm it behaves as expected.

[tristpinsm]

what would be easy to do is put in some log statements and play with the verbosity to confirm it behaves as expected.

OK I've done that and don't see messages logged at S.LOG_INFO level.

[msilvafe]

Ok, great. Not an issue for this PR but how do we change the log levels for the pysmurf logger if someone wanted to get the bias step messages back?

[tristpinsm]

Ok, great. Not an issue for this PR but how do we change the log levels for the pysmurf logger if someone wanted to get the bias step messages back?

It's not very obvious, but you can set it with verbose argument to the smurf client object instantiation, or set it later using the set_verbose method. e.g. here