Hostmanager + jackhammer compatibility#451
Merged
Conversation
Collaborator
Author
|
I've tested this with satp3 and its good to merge! One thing is that there was an issue (simonsobs/ocs#425) that required us to change all The old |
msilvafe
approved these changes
Feb 13, 2025
Contributor
msilvafe
left a comment
msilvafe
left a comment
There was a problem hiding this comment.
We need to send out some sort of slack blast to smurf users to let them know that docker-compose is no longer used but I think its time. This change happened a while ago now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the near future, we want to get hostmanager operating on smurf-servers to automatically start ocs agents.
Once this is the case, we will not want to touch ocs dockers using jackhammer... it should all be managed by the hostmanager.
With this PR, if
sys_config["use_hostmanager"]is set to True, it will exclude ocs dockers from any hammer operations.When setting this up, we will need to move ocs-related docker services to an independent docker-compose file to keep host-manager from interacting with smurf-streamer dockers, as is done here: https://github.com/simonsobs/ocs-deployment-configs/pull/332.