Bugfix: if not Win32 then BYTE, WORD, DWORD are now correctly set#9
Open
gnaray wants to merge 1 commit intosimonowen:masterfrom
Open
Bugfix: if not Win32 then BYTE, WORD, DWORD are now correctly set#9gnaray wants to merge 1 commit intosimonowen:masterfrom
gnaray wants to merge 1 commit intosimonowen:masterfrom
Conversation
…unsigned in CommonTypes.h. The proper include is also added (cstdint). Probably these 3 types are not used at all, removing this #ifndef _WIN32 block should also work. The problem was that these 3 types are defined as unsigned in Linux (and in Windows anyway) and these signed redefined types conflicted with those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix: if not Win32 then BYTE, WORD, DWORD are now correctly set as unsigned in CommonTypes.h.
The proper include is also added (cstdint).
Probably these 3 types are not used at all, removing this #ifndef _WIN32 block should also work.
The problem was that these 3 types are defined as unsigned in Linux (and in Windows anyway) and these signed redefined types conflicted with those.