Added support for diffing specific symbols in .o files#154
Open
Adubbz wants to merge 2 commits intosimonlindholm:mainfrom
Open
Added support for diffing specific symbols in .o files#154Adubbz wants to merge 2 commits intosimonlindholm:mainfrom
Adubbz wants to merge 2 commits intosimonlindholm:mainfrom
Conversation
Owner
|
Sorry for being enormously late to get to this. Isn't the parameter you'd pass to this always the same as the function name you already pass in, so now you'd pass it twice? Feels like there's a lot of overlap with the -s flag, too. (But a more reliable -s that's based on symbol boundaries would be a good thing.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title