Skip to content

Conversation

@ntrrgc
Copy link
Contributor

@ntrrgc ntrrgc commented Oct 6, 2025

Using a regular file instead of a pipe prevents ffmpeg from blocking indefinitely waiting for the euphony to read -- which it never does until the ffmpeg subprocess exits.

Fixes #1

Using a regular file instead of a pipe prevents ffmpeg from blocking
indefinitely waiting for the euphony to read -- which it never does
until the ffmpeg subprocess exits.

Fixes simongoricar#1
@simongoricar
Copy link
Owner

simongoricar commented Oct 7, 2025

Oops, don't mind the CI fail, I cancelled it because I forgot to update runs-on to use ubuntu-latest instead of self-hosted that I was experimenting with.

@simongoricar
Copy link
Owner

Hi, I thought about it and looked into it a bit, and it turns out that we can still avoid creating temporary files by using anonymous pipes (see std::io::pipe).

But I think we can still merge this fix for a start until that's done, and we can look into improvements for this on the linked issue.

@simongoricar simongoricar merged commit 961b86c into simongoricar:master Oct 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TranscodeAudioFileJob::run() is prone to deadlocks

2 participants