Allow ConfettiType.image to specify bundle #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do believe this applies to images in general within a swift package, however I am nearly certain this is needed for SVGs.
SVGs are “supported” in iOS apps via a process step. If you are inside of a swift package and want to use a SVG with ConfettiUI you are unable to. This is because
Image(String)within a swift package will not be able to find the image as it is processed by the package. To get this to work you need to addresources: [Resource.process("Media.xcassets")]to your package. This has the SVGs “processed” when the package is built (into what I do not know) and makes them accessible viaImage("image", bundle: packageBundle).All this change is doing is adding an optional bundle argument to the image type of
ConfettiTypethis way when you are in a package and wanting to use customConfettiTypeyou can just specify the bundle!Attached is a quick test of this. There are two packages in the zip. One has this change, the other demonstrates having a svg for confetti and using this change to use it with
ConfettiUI.Demo Packages.zip