Open
Conversation
rvashurin
requested changes
Oct 9, 2024
scripts/polygraph_eval
Outdated
| os.chdir(hydra.utils.get_original_cwd()) | ||
|
|
||
| save_path = args.save_path if "save_path" in args else save_path | ||
| output_prr_curves = getattr(args, "output_prr_curves", False) |
Collaborator
There was a problem hiding this comment.
Лучше это прям при создании менеджера ниже по коду делать, а то большой промежуток получается между местом где объявляется это и где потом используется
| if self.max_rejection == 1: | ||
| return "prr" | ||
| return f"prr_{self.max_rejection}" | ||
| return "prr" |
Collaborator
There was a problem hiding this comment.
Вот это наверное опечатка
|
|
||
| value = [] | ||
| for i in range(num_iter): | ||
| prr_values = [] # To store PRR scores across iterations |
Collaborator
There was a problem hiding this comment.
Посмотри мои комментарии насчет нейминга в этой функции из прошлого ПРа
src/lm_polygraph/utils/manager.py
Outdated
| 'cpu' otherwise. Default: None. | ||
| language (str): Language to test in claim-level benchmark, one of 'en', 'zh', 'ar', 'ru'. Default: 'en'. | ||
| verbose (bool): If set, will print useful info during batch processing. Default: True. | ||
| verbose for (e_level, e_name), estimator_values in self.estimations.items(): |
src/lm_polygraph/utils/manager.py
Outdated
| s | ||
| for e in self.ensemble_estimators | ||
| for s in e.stats_dependencies | ||
| for s in e.stats_dependenciesgenerate_prr_curve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback for previous pull