Add property declarations for defined app modules#185
Merged
cviebrock merged 3 commits intosilverorange:masterfrom Nov 20, 2025
Merged
Add property declarations for defined app modules#185cviebrock merged 3 commits intosilverorange:masterfrom
cviebrock merged 3 commits intosilverorange:masterfrom
Conversation
cviebrock
reviewed
Nov 19, 2025
| */ | ||
| class StoreCacheTableUpdater extends SiteCommandLineApplication | ||
| { | ||
| public MDB2_Driver_Common $db; |
Contributor
There was a problem hiding this comment.
Above, we set the type with a docblock comment. The worry I have with explicitly typing the property would be that we run into the "access before setting" issue ... in which case it needs to be nullable (and then we need to do null checks throughout the code).
Any concerns on your end?
Member
Author
There was a problem hiding this comment.
I had that concern as well. I did test the cache table updater and it runs correctly. I think if we ever had a access before setting issue in the code, we'd also have a null-dereference issue as none of the code checks for null on this property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds PHPstan property declarations for module definitions.
Testing Instructions (optional)
Add step-by-step instructions for testing the PR, if necessary.
Developer Checklist
Before requesting review for this PR, make sure the following tasks are
complete:
Reviewer Checklist
Before merging this PR, make sure the following tasks are complete: