Skip to content

Product details item groups read property on null fix #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gauthierm merged 1 commit into from
Oct 10, 2025
Merged

Product details item groups read property on null fix #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Store/admin/components/Product/Details.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,13 +1125,17 @@ private function buildItemGroups()
$groups = $this->queryItemGroups();
$has_items = (count($groups) > 0);

// if there is one row and the groupnum is 0 then there are no
// if there is now rows or one row and the groupnum is 0 then there are no
// item_groups with items in them for this product. If $groups has 0
// elements, there are no items

if (count($groups) == 1 && $groups->getFirst()->item_group == 0) {
$first_group = $groups->getFirst();
if (
$first_group === null ||
(count($groups) === 1 && $first_group->item_group === 0)
) {
$num_groups = 0;
} elseif ($groups->getFirst()->item_group == 0) {
} elseif ($first_group->item_group === 0) {
$num_groups = count($groups) - 1;
} else {
$num_groups = count($groups);
Expand Down
Loading